Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faker::SouthPark => Faker::Movies::SouthPark #1403

Merged
merged 3 commits into from
Oct 12, 2018
Merged

Faker::SouthPark => Faker::Movies::SouthPark #1403

merged 3 commits into from
Oct 12, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Oct 12, 2018

We don't need a description for this PR because the title describes the changes very well.

We don't need to deprecate this method because we haven't released it yet, that's why I decided to add a namespace before releasing it.

Faker::SouthPark was introduced in this PR: #1314

@vbrazo vbrazo added the Chores label Oct 12, 2018
@vbrazo vbrazo self-assigned this Oct 12, 2018
@vbrazo vbrazo mentioned this pull request Oct 12, 2018
@vbrazo vbrazo merged commit 80f6f2b into faker-ruby:master Oct 12, 2018
@vbrazo vbrazo deleted the chores/add-namespace-to-faker-south-park branch October 12, 2018 04:00
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Faker::SouthPark => Faker::Movies::SouthPark

* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant