Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middle_name to other locales #1395

Merged
merged 4 commits into from
Oct 11, 2018
Merged

Add middle_name to other locales #1395

merged 4 commits into from
Oct 11, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Oct 11, 2018

Checklist

  • Add middle_name to several locales that were missing this method
  • Add tests for these new additions
  • Organize tests to improve readability

@vbrazo vbrazo self-assigned this Oct 11, 2018
@vbrazo vbrazo merged commit 852b84d into faker-ruby:master Oct 11, 2018
@vbrazo vbrazo deleted the locales/add-middlename-to-all-locales branch October 11, 2018 12:12
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Update locale tests

* Update CHANGELOG.md

* Add name_with_middle to ja.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant