Fix Company.luhn_algorithm and add missing tests. #1335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some issues with Faker::Company.luhn_algorithm(number) :
number
The problem was that
luhn_algorithm
didn't reverse thenumber
submitted argument before splitting it (as it should).This forgotten reverse resulted in the generation of non "luhn-compliant" strings for even length
number
.No issue for odd length arguments ([9,4,6] vs [6,4,9]), only with even ([8,6,4] vs [3,9,7]).
This commit fixes the issue and add
test_luhn_algorithm
to avoid future issues.