Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Faker::DC Comics #1319

Merged
merged 6 commits into from
Jul 28, 2018
Merged

Added Faker::DC Comics #1319

merged 6 commits into from
Jul 28, 2018

Conversation

JoelLindow
Copy link
Contributor

@JoelLindow JoelLindow commented Jul 27, 2018

  • All requirements from Faker Contribution guidelines met.
  • Tests Passing.
  • RuboCop Satisfied.
  • Documentation Completed
  • README.md file edited to include this Faker library and link to documentation.

Fun new library including:

  • DC Heroes
  • DC Heroines
  • DC Villains
  • DC Names (Hero alter egos, villain alter egos, other random characters)

@JoelLindow JoelLindow changed the title DC Comics Faker Complete. Added Faker::DC Comics Jul 27, 2018
JoelLindow and others added 4 commits July 26, 2018 21:50
Copied from Breaking Bad Documentation for proper layout. Removing Breaking Bad reference and replacing with DC reference. Should be last remaining error in documentation
@vbrazo vbrazo merged commit 793b68b into faker-ruby:master Jul 28, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* DC Comics Faker Complete. Tests Passing. RuboCop Satisfied

* Documentation Added

* README.md edited to include documentation link

* Update dc_comics.md

* Update change

Copied from Breaking Bad Documentation for proper layout. Removing Breaking Bad reference and replacing with DC reference. Should be last remaining error in documentation

* Update dc_comics.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants