Add Faker::SouthPark #1314
Merged
Add Faker::SouthPark #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,15 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
Magic comment added by Rubocop
There was a problem hiding this comment.
#1311 may explain the magic comments.
vbrazo
approved these changes
Jul 17, 2018
|
Sure @vbrazo, will update the |
|
@vbrazo Done, Updated |
|
@saurabhudaniya200 just a heads up: I'm adding a namespace for your SouthPark in this PR #1403. Since we haven't released this object yet, we don't need to deprecate it. Thanks 👍 |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Added south park feature * Renamed south_park.doc to south_park.md * Updated README to reflect newly added SouthPark feature * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature request for South Park consisting 55 characters and 17 quotes
Tests
1092 tests, 79817 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed
Rubocop
358 files inspected, no offenses detected