Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Restaurant #1313

Merged
merged 4 commits into from
Jul 17, 2018
Merged

Add Faker::Restaurant #1313

merged 4 commits into from
Jul 17, 2018

Conversation

dwhitlow
Copy link

Add fakes for businesses that sell food and/or beverages.

@dwhitlow
Add Faker::Restaurant
bac831d 
Add fakes for businesses that sell food and/or beverages.
@vbrazo vbrazo self-requested a review July 17, 2018 02:14
@vbrazo vbrazo assigned vbrazo and dwhitlow and unassigned vbrazo Jul 17, 2018
vbrazo
vbrazo reviewed Jul 17, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

You should create the doc/restaurant.md and update our README.md.

I reviewed a PR a few weeks ago and the contributor hasn't replied me yet. Could you check #1145 out and see if you could add a few more locales to your contribution? The PR has other methods, go ahead and use them.

@dwhitlow
Copy link
Author

dwhitlow commented Jul 17, 2018 •
edited
Loading

Hey @vbrazo,

Thanks for the quick review. I don't speak any other languages fluently, and the PR you referenced doesn't appear to have any other locales, so I can't add any additional ones. I think PhraseApp still offers free translation for open source projects, if that's a concern.

I'm adding another commit to add Restaurant::description and Restaurant::review. It seems like the operating hour feature would be better off as a separate addition to Faker::Business, though.

@vbrazo
Copy link
Member

vbrazo commented Jul 17, 2018

Sounds like a plan. I'll review your PR again once you push new commits 👍

@vbrazo
Copy link
Member

vbrazo commented Jul 17, 2018 •
edited
Loading

I tested locally and it looks fine 👍 welcome bro!

@vbrazo vbrazo merged commit 089a52f into faker-ruby:master Jul 17, 2018
@vbrazo vbrazo mentioned this pull request Jul 17, 2018
Closed
@dwhitlow dwhitlow deleted the restaurant branch July 17, 2018 03:31
@dwhitlow
Copy link
Author

Thanks for the quick merge!

@vbrazo vbrazo self-requested a review July 19, 2018 01:19
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Add Faker::Restaurant (faker-ruby#1313)
f3da128 
* Add Faker::Restaurant

Add fakes for businesses that sell food and/or beverages.

* Add ::description and ::review to Restaurant

Copy taken from faker-ruby#1145

* Add restaurant.md link to README

* Bug/typo fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@dwhitlow dwhitlow

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwhitlow @vbrazo