Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for middle_name and remove locale #1310

Merged
merged 4 commits into from
Jul 12, 2018
Merged

Add alias for middle_name and remove locale #1310

merged 4 commits into from
Jul 12, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Jul 12, 2018

  • middle_name should be a sample of last_name
  • remove middle_name locale
  • check if middle_name has a test and its docs

@vbrazo vbrazo self-assigned this Jul 12, 2018
@vbrazo vbrazo merged commit cfe998c into faker-ruby:master Jul 12, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add alias for middle_name and remove locale

* Update changelog

* Update contributing.md

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant