Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::GreekPhilosophers #1300

Merged
merged 4 commits into from
Jul 4, 2018
Merged

Conversation

15ngburton
Copy link
Contributor

Creates the Faker::GreekPhilosophers class which allows one to retrieve randomized names and quotes of Classical Era Greek philosophers. Comes with tests and documentation.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left a comment about the documentation. You should also update our README.md and add the docs link there. Thanks a lot for contributing and welcome 👍

@@ -0,0 +1,9 @@
# Faker::GreekPhilosophers

Available since version 1.6.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.6.2? I believe it should be It might be available in the next version.

@vbrazo vbrazo changed the title Added greek philosophers class, yaml file, test, and doc Add Faker::GreekPhilosophers Jul 4, 2018
@vbrazo
Copy link
Member

vbrazo commented Jul 4, 2018

Since the changes were pretty trivial, I decided to go ahead and make the changes. Thanks again.

@vbrazo vbrazo merged commit a20adad into faker-ruby:master Jul 4, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:21
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Added greek philosophers class, yaml file, test, and doc

* Update CHANGELOG.md

* Update README.md

* Update greek_philosophers.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants