Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::HarryPotter.spell #1279

Merged
merged 4 commits into from
Jun 11, 2018
Merged

Add Faker::HarryPotter.spell #1279

merged 4 commits into from
Jun 11, 2018

Conversation

A9u
Copy link

@A9u A9u commented Jun 11, 2018

  • Added Faker::HarryPotter.spell
  • Updated locales, docs, tests

vbrazo
vbrazo approved these changes Jun 11, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍 Thanks for contributing 🥇

@vbrazo vbrazo merged commit c7f21a0 into faker-ruby:master Jun 11, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:21
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Add Faker::HarryPotter.spell (faker-ruby#1279)
ddff0d1 
* added spell in Harry Potter
* added new method spell

* updated doc

* Update changelog

* Minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@A9u A9u

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A9u @vbrazo