Add fr_CH locale #1261
Merged
Add fr_CH locale #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
requested changes
May 29, 2018
There was a problem hiding this comment.
Thanks for contributing.
The locales look good. Please add tests for them.
Check this example out https://github.com/stympy/faker/blob/master/test/test_tr_locale.rb
|
Ok, I will add the tests. Thanks for the review. |
vbrazo
approved these changes
Jun 5, 2018
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add fr_CH locale * Add fr ch locale tests * Update changelog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some basic translations for fr_CH locale.
I used information about phone numbers, states street names, etc... to fill the fields I need for my project.