Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dessert faker #1236

Merged
merged 8 commits into from
May 21, 2018
Merged

Updates dessert faker #1236

merged 8 commits into from
May 21, 2018

Conversation

susiirwin
Copy link
Contributor

This is updating the dessert faker module.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contributing🥇

end

def test_flavor
assert @tester.flavor.match(/\w+\.?/)
assert @tester.flavor.match(/\w+/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

@vbrazo vbrazo merged commit b6ad95f into faker-ruby:master May 21, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:32
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add Dessert Faker with Variety, Topping, and Flavor Options.

* Update Documentation for Dessert Faker

* Updates dessert class and tests

* Removes unneeded line

* Updated tests to fix rubocop

* Adds a few more options to the dessert yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants