Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Faker::Myst #1220

Merged
merged 5 commits into from
May 18, 2018
Merged

Updates for Faker::Myst #1220

merged 5 commits into from
May 18, 2018

Conversation

Zeragamba
Copy link
Contributor

  • Adding the missing documentation
  • rename Myst.person to Myst.character
    • matches better with other modules
  • fix some typos

@Zeragamba
Copy link
Contributor Author

@vbrazo here's the changes you requested from #1218

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2157

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 99.647%
Totals Coverage Status
Change from base Build 2154: 0.02%
Covered Lines: 2260
Relevant Lines: 2268
💛 - Coveralls

@faker-ruby faker-ruby deleted a comment from coveralls May 18, 2018
@faker-ruby faker-ruby deleted a comment from coveralls May 18, 2018
@faker-ruby faker-ruby deleted a comment from coveralls May 18, 2018
vbrazo
vbrazo approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍

@vbrazo vbrazo merged commit 0d9636d into faker-ruby:master May 18, 2018
@Zeragamba Zeragamba deleted the Myst branch May 18, 2018 11:59
vbrazo
vbrazo reviewed Jun 14, 2018
View reviewed changes
lib/faker/myst.rb
def person
fetch('myst.people')
def character
fetch('myst.characters')
end
Copy link
Member

@vbrazo vbrazo Jun 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new object that was creating in this PR #1218 (not released yet), we don't need to deprecate this method.

@vbrazo vbrazo self-requested a review July 19, 2018 01:27
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@Zeragamba @vbrazo
Updates for Faker::Myst (faker-ruby#1220)
e833f77 
* Rename Myst.person to Myst.creature
- fits better with other modules

* Add documentation for Faker::Myst

* Fix some typos in Faker::Myst

* Add Faker::Myst to faker readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@Zeragamba Zeragamba

Labels
📘 Documentation 💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeragamba @coveralls @vbrazo