Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Myst #1218

Merged
merged 1 commit into from
May 17, 2018
Merged

Add Faker::Myst #1218

merged 1 commit into from
May 17, 2018

Conversation

Zeragamba
Copy link
Contributor

@Zeragamba Zeragamba commented May 17, 2018 •
edited
Loading

Add ages, games, quotes, and people from the Myst series

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2149

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.647%
Totals Coverage Status
Change from base Build 2148: 0.002%
Covered Lines: 2260
Relevant Lines: 2268
💛 - Coveralls

@Zeragamba Zeragamba changed the title Add Myst module Add Faker::Myst May 17, 2018
@faker-ruby faker-ruby deleted a comment from coveralls May 17, 2018
@faker-ruby faker-ruby deleted a comment from coveralls May 17, 2018
@vbrazo vbrazo self-requested a review May 17, 2018 23:29
@faker-ruby faker-ruby deleted a comment from coveralls May 17, 2018
@vbrazo vbrazo merged commit 1554685 into faker-ruby:master May 17, 2018
@vbrazo
Copy link
Member

vbrazo commented May 17, 2018

@SpyMaster356 I forgot to ask you to change the CHANGELOG.md and add the title of this PR + your GitHub ID. Besides that, you should've added docs. Could you please open another PR and make sure to include these considerations?

vbrazo added a commit that referenced this pull request May 17, 2018
@vbrazo
Revert "Add Myst module (#1218)"
fb5a28b 
This reverts commit 1554685.
@vbrazo
Copy link
Member

vbrazo commented May 18, 2018

@SpyMaster356 I just pushed a commit to add this PR to the changelog.md. So do not worry about that.

Let me know if you need help to finish the Faker::Myst docs.

@Zeragamba
Copy link
Contributor Author

Oops, i knew i was forgetting something. I'll add the docs in

@Zeragamba Zeragamba mentioned this pull request May 18, 2018
Merged
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@Zeragamba @vbrazo
Add Myst module (faker-ruby#1218)
e68765c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@Zeragamba Zeragamba

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeragamba @coveralls @vbrazo