Add missing tests after adding Coveralls #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
changed the title
Pull Request Test Coverage Report for Build 2123
💛 - Coveralls |
vbrazo
force-pushed
the
fixtures/add-missing-specs
branch
from
c534011
to
1aa3435
Compare
vbrazo
force-pushed
the
fixtures/add-missing-specs
branch
from
b7cf550
to
f1a785c
Compare
vbrazo
commented
Jun 9, 2018
|
|
||
| Faker::Measurement.metric_weight_none #=> "gram" | ||
|
|
||
| Faker::Measurement.metric_weight_all #=> "grams" |
There was a problem hiding this comment.
I just reverted the measurement object changes in this commit. They were incorrect.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
…pecs Add missing tests after adding Coveralls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coveralls is showing us that we are missing a bunch of tests and the goal of this PR is to solve several testing issue/add missing tests.
Feel free to pull this branch and contribute.