Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::MichaelScott API #1193

Merged
merged 3 commits into from
May 12, 2018
Merged

Add Faker::MichaelScott API #1193

merged 3 commits into from
May 12, 2018

Conversation

snayrouz
Copy link
Contributor

In this Pull Request:

  • Fix duplicate quote
  • Add unit test for Michael Scott quotes
  • Add module for Michael Scott quotes
  • Add yml file for storage of Michael Scott quotes
  • Add markdown file to show sample of functionality

@vbrazo
Copy link
Member

vbrazo commented May 12, 2018

Looks good to me.
Nice work, congrats @snayrouz 👏 👏 👏

@vbrazo vbrazo self-requested a review May 12, 2018 15:27
@vbrazo vbrazo merged commit f0961dd into faker-ruby:master May 12, 2018
@vbrazo vbrazo changed the title Michael Scott Quotes Add Michael Scott Quotes Object May 16, 2018
@vbrazo vbrazo changed the title Add Michael Scott Quotes Object Add Faker::MichaelScott API May 16, 2018
@snayrouz snayrouz deleted the tests branch June 1, 2018 04:21
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants