Add Nation object, its specs and docs #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing commas? [... Azeris Bahamians Bahrainis, Bangladeshis Barbadians,...] |
|
Thanks @timcustard for the feedback. I will update PR ASAP. |
|
@timcustard @stympy can you check this review. :) |
|
I'm afraid you've added commas between "British, Virgin, Islanders,", which I'm guessing should be a single string? |
|
@timcustard I will recheck and verify. |
|
@timcustard can you please check this PR once again. |
|
Looks good to me :) |
vbrazo
reviewed
Apr 29, 2018
README.md
Outdated
| @@ -125,6 +125,7 @@ Contents | |||
| - [Faker::Witcher](doc/witcher.md) | |||
| - [Faker::WorldOfWarcraft](doc/world_of_warcraft.md) | |||
| - [Faker::Zelda](doc/zelda.md) | |||
| - [Faker::Nation](doc/nation.md) | |||
There was a problem hiding this comment.
I'd order the items in the README.md.
|
@stympy can you please check this PR? |
gkunwar
changed the title
gkunwar
changed the title
|
@vbrazo can you please check this PR. I have updated the readme. |
|
It looks good to me @gkunwar |
vbrazo
changed the title
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
Nationality: Added Nationality and National Languages of random Nation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives random