Fix Fixnum reference warning #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
…reference Fix Fixnum reference warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Ruby-2.4.0 release,
FixnumandBignumare combined into Integer class. This PR is to fix allFixnumwarnings. Are you interested in learning more? https://bugs.ruby-lang.org/issues/12005Notice that I added a few
RUBY_VERSIONif statements, because Travis is testing a few versions of Ruby: 2.1.10, 2.2.7, 2.3.4 and 2.4.1. Otherwise Travis would fail and I wouldn't have gotten the green flag.I opened an issue #1171 for this PR - take a look at the first bullet point.