Modify Faker::Internet.slug #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: slug('Something Co., Ltd.','-')
=> "something-co.,-ltd."
After: slug('Something Co., Ltd.','-')
=> "something-co-ltd"
vbrazo
reviewed
May 14, 2018
lib/faker/internet.rb
Outdated
| @@ -161,7 +161,7 @@ def url(host = domain_name, path = "/#{user_name}", scheme = 'http') | |||
|
|
|||
| def slug(words = nil, glue = nil) | |||
| glue ||= sample(%w[- _ .]) | |||
| (words || Faker::Lorem::words(2).join(' ')).gsub(' ', glue).downcase | |||
| (words || Faker::Lorem::words(2).join(' ')).delete(',.').gsub(' ', glue).downcase | |||
There was a problem hiding this comment.
@philduffen Could you write/modify the tests to make sure your new changes are working properly?
vbrazo
changed the title
vbrazo
approved these changes
May 15, 2018
| @@ -217,6 +217,10 @@ def test_slug_with_content_arg | |||
| assert @tester.slug('Foo bAr baZ').match(/^foo(_|\.|\-)bar(_|\.|\-)baz$/) | |||
| end | |||
|
|
|||
| def test_slug_with_unwanted_content_arg | |||
| assert @tester.slug('Foo.. bAr., baZ,,').match(/^foo(_|\.|\-)bar(_|\.|\-)baz$/) | |||
| end | |||
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Modify Modify Faker::Internet.slug
Before: slug('Something Co., Ltd.','-')
=> "something-co.,-ltd."
After: slug('Something Co., Ltd.','-')
=> "something-co-ltd"
* Add test for unwanted slug content i.e. extraneous commas and full stops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: slug('Something Co., Ltd.','-')
=> "something-co.,-ltd."
After: slug('Something Co., Ltd.','-')
=> "something-co-ltd"