Added documentation for dumb and dumber #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
May 14, 2018
doc/dumb_and_dumber.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| # Faker::Seinfeld | |||
|
@cnharris10 Looks good 👍 Just two minor fixes. Please write a great description for this PR as well. |
vbrazo
reviewed
May 14, 2018
README.md
Outdated
| @@ -53,6 +53,7 @@ Contents | |||
| - [Faker::DragonBall](doc/dragon_ball.md) | |||
| - [Faker::DrWho](doc/dr_who.md) | |||
| - [Faker::Dune](doc/dune.md) | |||
| - [Faker::DumbAndDumber](doc/dumb_and_dumber.md) | |||
There was a problem hiding this comment.
It should be ordered by name, so DumbAndDumber should come first.
|
Thanks |
Pull Request Test Coverage Report for Build 2027
💛 - Coveralls |
vbrazo
approved these changes
May 16, 2018
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Added documentation for dumb and dumber * Update README.md * Update dumb_and_dumber.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Dumb and Dumber codex to README.
"I expected the
Rocky MountainsREADME.md to be a littlerockiermore detailed than this."-Harry Dunn
“I was thinking the same thing. That
John Denver’sChris Harris's full of shit, man.”-Lloyd Christmas