Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Princess Bride #1109

Merged
merged 1 commit into from
May 21, 2018
Merged

Added Princess Bride #1109

merged 1 commit into from
May 21, 2018

Conversation

jayphodges
Copy link
Contributor

Added Princess Bride character and quotes with associated docs and test file.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you rebase with master and fix the Rubocop violations?

@vbrazo vbrazo force-pushed the master branch 3 times, most recently from 6394a28 to d11bd7e Compare May 20, 2018 20:41
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR and I'll do the rebase if needed.

Thanks for contributing 🥇

Looking forward to seeing your new PRs. Welcome.

@vbrazo vbrazo merged commit 3f09d03 into faker-ruby:master May 21, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:25
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants