Adds turkish phone number formats and test. #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get a review on this @stympy |
vbrazo
requested changes
May 19, 2018
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
6394a28
to
d11bd7e
Compare
Adds changelog and fixes violations Adds turkish phone number formats and a test. Adds changelog and fixes violations
ZASMan
force-pushed
the
add_turkish_phone_formats
branch
from
5695852
to
36edc5f
Compare
|
yes sir, I think I have it now! |
vbrazo
approved these changes
May 22, 2018
vbrazo
reviewed
May 22, 2018
| @@ -33,6 +33,10 @@ def test_tr_address_fields | |||
| assert Faker::Address.country.is_a? String | |||
| end | |||
|
|
|||
| def test_tr_phone_number_fields | |||
| assert Faker::PhoneNumber.phone_number.is_a? String | |||
| end | |||
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Adds turkish phone number formats and a test. Adds changelog and fixes violations Adds turkish phone number formats and a test. Adds changelog and fixes violations * Updates changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some formatting for turkish phone numbers with
90country code and a test.