Add Faker::Ethereum #1004
Merged
Add Faker::Ethereum #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not merge this change |
vbrazo
requested changes
May 19, 2018
vbrazo
force-pushed
the
master
branch
4 times, most recently
from
a359def
to
a5d7731
Compare
vbrazo
requested changes
Jun 2, 2018
There was a problem hiding this comment.
@kaizenx a couple of small things:
- You should also update the
README.mdand add theEthereumlink, so users will be able to see your new object. All the objects are there. - Besides that, we should create another documentation file:
doc/ethereum.md.
vbrazo
approved these changes
Jul 1, 2018
|
I finished the changes @kaizenx thanks for contributing :) |
gaga5lala
pushed a commit
to gaga5lala/faker
that referenced
this pull request
Feb 4, 2019
The eth address in the example result is invalid.
vbrazo
pushed a commit
that referenced
this pull request
Feb 4, 2019
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
Add Faker::Ethereum
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
The eth address in the example result is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an Ethereum public address generator at
lib/faker/ethereum.rb
The faker generates a random 40 character hex string and concatenates it with a leading "0x"
Added a test for it at
test/test_faker_ethereum.rb
The test is a simple regex format check.