Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate experimental preprocess mode #1619

Closed
1 of 3 tasks
kitten opened this issue Mar 18, 2018 · 10 comments
Closed
1 of 3 tasks

Deprecate experimental preprocess mode #1619

kitten opened this issue Mar 18, 2018 · 10 comments

Comments

@kitten
Copy link
Member

kitten commented Mar 18, 2018

We had this preprocess mode for a while which has been replaced by our ISTF/Sweetsour effort. The old approach was deeply flawed and is borderline unusable.

I still see people from time to time who are switching it on, believing that it would work as intended.

This task involves the deprecation (and future removal potentially) of this mode, so that we can delete its bundles.

The tasks under this umbrella issue are:

  • Deprecate preprocess bundle (add warning)
  • Remove preprocess bundle (in a future major, separate PR)
  • Remove preprocess code and flag from babel plugin
@samatar26
Copy link
Member

@kitten Can I work on this one?

@mxstbr
Copy link
Member

mxstbr commented Mar 19, 2018

Yes please!

@kitten
Copy link
Member Author

kitten commented Mar 19, 2018

@samatar26 Absolutely! And please let me know if you need any help 🙌

@chengjianhua
Copy link

@kitten Hi ~ I'm very curious about the progress of the ISTF since I read the article you wrote. Could you mind to open a issue to introduce the great works you have done ?

It's amazing 😍 and I'm waiting for the appearance of the implementation, but I can't know any state changes about it, so sad 🙈. I'll appreciate that if you can introduce more progress about the ISTF, thx ~

@kitten
Copy link
Member Author

kitten commented Mar 21, 2018

@chengjianhua hiya :) the latest progress can be seen on the Sweetsour repo. https://github.com/kitten/sweetsour

I’m mindful of posting any kind of timeline as I don’t have time to work on it continuously. That being said the parser itself is pretty much done and the next idea on how to proceed might be #1617

@rodocite
Copy link

@kitten Was surfing the issues and saw this. I know @samatar26 is working on it, but was just wondering if this block is what you're talking about:

@kitten
Copy link
Member Author

kitten commented Mar 30, 2018

The deprecation warning is in place, so we'd only need someone to help out and jump onto updating the babel plugin now 👍 ❤️

@samatar26
Copy link
Member

@kitten working on it 👍

@quantizor
Copy link
Contributor

It's dead and deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants