Using "Server" HTTP header is not a reliable mechanism for detecting S3 implementation

[stv0g]

So, I fixed the final issue with the final checksum mismatch and tested it with the included docker-compose.yml file.

Let me know if works for you :)

got yet another issue i'm afraid, since i have my domain routed through cloudflare gose now thinks i'm using cloudflare s3 and not minio

Originally posted by @LeagueRaINi in #23 (comment)

[stv0g]

I started to dig around a bit deeper and found here the RFC which specifies the Server header: RFC2616 (section 14.38):

The Server response-header field contains information about the software used by the origin server to handle the request.

It explicitly mentions:

If the response is being forwarded through a proxy, the proxy application MUST NOT modify the Server response-header. Instead, it SHOULD include a Via field (as described in section 14.45).

So I think Cloudflare is not complying to the RFC here.

@LeagueRaINi Can you check if your can disable this behaviour in your Cloudfare setup?

[LeagueRaINi]

not sure where i would change that in the cloudflare control panel to be honest, why not allow overwriting the s3 server impl in the config?

[stv0g]

Oh yeah, thats probably the simplest solution. I will implement this.

[stv0g]

Hi @LeagueRaINi

I've added some new settings:

GOSE_IMPLEMENTATION = MinIO

which implies the following settings which disable unsupported features by MinIO:

GOSE_SETUP_CORS = false
GOSE_SETUP_ABORT_INCOMPLETE_UPLOADS = 0

I havn`t tested the code so feedback would be appreciated :)

[LeagueRaINi]

looks like everything is working now thanks :)