Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Books Not Sorting Correctly in Stump #482

Open
Ammoton opened this issue Oct 16, 2024 · 4 comments
Open

[BUG] Books Not Sorting Correctly in Stump #482

Ammoton opened this issue Oct 16, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Ammoton
Copy link

Ammoton commented Oct 16, 2024

Description of the Bug

Books that are named Volume 1, Volume 2, Volume 3, ... are sorted incorrectly.

They appear in this order:

1
10
11
...
19
2
20

Expected Behavior

They should be sorted like this:

1
2
3
...
9
10
11

Environment:

  • OS: [Windows]

Build Details:

  • Version: [0.0.7]
  • Docker: [no]
@Ammoton Ammoton added the bug Something isn't working label Oct 16, 2024
@aaronleopold
Copy link
Collaborator

Books that are named Volume 1, Volume 2, Volume 3, ... are sorted incorrectly.

When you say named, are you referring to the filename (e.g. Volume 1.zip) or the name pulled from metadata?

@Ammoton
Copy link
Author

Ammoton commented Oct 17, 2024

I'm referring to the filename. But the title in the metadata is also set. I tested a little more, and if I only use the filename without metadata, it's not sorted correctly. If I use metadata (title) and filenames like 01, 02, etc., it works. But if I use 1, 2, etc., it doesn't. Could it be that the filename is prioritized?

@aaronleopold
Copy link
Collaborator

aaronleopold commented Oct 17, 2024

Yeah IIRC the filename is most likely what is being prioritized at the moment. Coincidentally I started a refactor for the sorting implementation a week or so ago here. I think I'll try to explore fixing this issue there, once what I have is viable, as it makes ordering by relations (i.e. the metadata) more possible.

I'll report back once I have something. Thanks for letting me know!

@aaronleopold
Copy link
Collaborator

aaronleopold commented Nov 26, 2024

I wanted to post a little update just to say I haven't forgotten about this. I have a viable fix seemingly working, but there is a lot of UI work associated with the overhaul to how ordering and filtering works. My progress is contained to this branch for any code-savvy followers: https://github.com/stumpapp/stump/tree/experiment/pin-prisma. I'll aim to get it into experimental by the end of December, ideally

@github-project-automation github-project-automation bot moved this to Backlog in v0.1.x Dec 4, 2024
@aaronleopold aaronleopold moved this from Backlog to Up Next in v0.1.x Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Up Next
Development

No branches or pull requests

2 participants