Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] QoL epubs #378

Open
hollisticated-horse opened this issue Jul 31, 2024 · 7 comments
Open

[FEATURE] QoL epubs #378

hollisticated-horse opened this issue Jul 31, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@hollisticated-horse
Copy link

hollisticated-horse commented Jul 31, 2024

Is your feature request related to a problem? Please describe.
A variety of things that would improve reading EPUBs.

Describe the solution you'd like

WIP Proposal:
  • adjustable line-heights
  • word spacing, by having some presets ?
  • margins around the whole book (top, bottom, left and right synced)
  • adjustable text-justify → left, right, center and justified.
  • have a progress bar instead of page numbers

Describe alternatives you've considered
n.a.

Additional context
Based of

  • KOReader
  • BookFusion
  • and other reading apps.
@hollisticated-horse hollisticated-horse added the enhancement New feature or request label Jul 31, 2024
@hollisticated-horse
Copy link
Author

hollisticated-horse commented Jul 31, 2024

I'd be happy to try to make some design drafts in a penpot we could share @aaronleopold

@aaronleopold
Copy link
Collaborator

have a progress bar instead of page numbers
interactive, be able to see small icons indicating highlights & bookmarks

I'm personally a HUGE fan of Yomu's progress bar, if you have seen it.

I'd be happy to try to make some design drafts in a penpot we could share

Absolutely! Any design help is extremely appreciated 🙂

@hollisticated-horse
Copy link
Author

hollisticated-horse commented Jul 31, 2024

I'm personally a HUGE fan of Yomu's progress bar, if you have seen it.

Oooh, I have not. It's mac/ios specific, but it would be really cool if you could find screenshots. :D
From the screenshot in the main page of the project, it does have a fairly minimalistic look. What is good about it ?

I find that the bookfusion one is decent, similar to foliate (linux, flathub). But not a lot of information displayed.

Absolutely! Any design help is extremely appreciated 🙂

I'll make a penpot project later, if you'd like ? I can send you an invite by email.
I'm a bit busy, but in a few weeks I should have more time. :D

@aaronleopold
Copy link
Collaborator

From the screenshot in the main page of the project, it does have a fairly minimalistic look. What is good about it ?

Yeah it's very minimalist, I'm just preferential to that kind of design in general. It chunks each chapter into blocks, then shows your relative position in the block for the current chapter. This is very difficult to do with EPUB.js, though.

I find that the bookfusion one is decent, similar to foliate (linux, flathub)

I haven't given bookfusion a proper look, a quick glance at the preview looks good too

I'll make a penpot project later, if you'd like ? I can send you an invite by email.
I'm a bit busy, but in a few weeks I should have more time. :D

No rush or expectations on my end. I haven't used penpot before, but email works

@hollisticated-horse
Copy link
Author

hollisticated-horse commented Sep 23, 2024

Here a first proposition:

https://design.penpot.app/#/view/c0ee57fd-603e-804a-8004-c6d33343fd51?page-id=c0ee57fd-603e-804a-8004-c6d33343fd52&section=interactions&index=0&share-id=c04641ea-355e-80b8-8005-0340b73be6c6

I'm thinking that the sections in the progress bar should reflect the toc and page counts ?

Inspired by Yomu's progress bar.

EDIT:

@aaronleopold updated the link

@aaronleopold
Copy link
Collaborator

https://design.penpot.app/#/view/c0ee57fd-603e-804a-8004-c6d33343fd51?page-id=c0ee57fd-603e-804a-8004-c6d33343fd52&section=interactions&index=0

I don't seem to have access. I thought maybe I would need an account to access, but still get the same error after creating one and trying the link:

This page might not exist or you don’t have permissions to access to it.

@aaronleopold
Copy link
Collaborator

I just took a look. I think it's good!

I'm thinking that the sections in the progress bar should reflect the toc and page counts

Yeah, that's how Yomu does it too. Each chapter (toc entry) is a block, and the fill is based on your current page in the current chapter. The caveat would be offhand I don't know how simple calculating that would be, mostly because to generate accurate sizing of previous chapters would mean we know how many pages are in each which is a lot of computation that would be reactive to any changes in the viewport size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants