Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failures for X64 and linux #17

Closed
siddhipai opened this issue Dec 9, 2016 · 3 comments
Closed

CI failures for X64 and linux #17

siddhipai opened this issue Dec 9, 2016 · 3 comments
Assignees

Comments

@siddhipai
Copy link
Contributor

see #16

@siddhipai siddhipai self-assigned this Dec 9, 2016
@rashmihunt
Copy link
Contributor

rashmihunt commented Jan 16, 2017

There are no test cases in loopback-oracle-installer because it's a installer code for loopback-connector oracle module. The only time a developer would run 'npm i' on loopback-oracle-installer would be in their dev environment when they are fixing an issue in loopback-oracle-installer . In this dev env, loopback-oracle-installer depends on loopback-oracle-builder to be it's pier node module (checked out at the same as loopback-oracle-installer module). In CI setup, loopback-oracle-builder is not available because it's not a dev env, hence the CI failures.

Ideally, CI shouldn't be running loopback-oracle-installer. Instead this CI should just run the CI for dependent module which is loopback-connector-oracle which will in-turn do 'npm i loopback-oracle-installer' which will test any change developer has made to loopback-oracle-installer. loopback-oracle-installer CI should ideally only kick off CI for loopback-connector-oracle.

@dhmlau
Copy link
Member

dhmlau commented Aug 16, 2017

CI failed for node 0.10 and 0.12. Since LB 3.x does not support these 2 node versions, we can fix CI by updating the package.json accordingly.

@dhmlau
Copy link
Member

dhmlau commented Apr 6, 2018

Closing as resolved.
Looking at the last merged PR, all CI passed.

@dhmlau dhmlau closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants