Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to get rid of Settings.plist #25

Open
benmarten opened this issue Feb 5, 2015 · 1 comment
Open

Suggestion to get rid of Settings.plist #25

benmarten opened this issue Feb 5, 2015 · 1 comment

Comments

@benmarten
Copy link

Today I configured Notification with LB iOS SDK.

I noticed, that the framework has hardcoded to reference: Settings.plist for e.g. AppId and AppVersion.

Since we have the version already in the Info.plist it would make much more sense to get the AppId and AppVersion from there.

@hideya
Copy link
Contributor

hideya commented Mar 18, 2015

That makes sense to me. Code like the following would be good:

NSDictionary *infoDict = [[NSBundle mainBundle] infoDictionary];
NSString *appId = [infoDict objectForKey:@"CFBundleName"];
NSString *appVersion = [infoDict objectForKey:@"CFBundleVersion"];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants