Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing categoricals to Glm as-is #30

Open
jwdink opened this issue Feb 1, 2023 · 0 comments
Open

Add support for passing categoricals to Glm as-is #30

jwdink opened this issue Feb 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jwdink
Copy link
Contributor

jwdink commented Feb 1, 2023

It would not be very difficult to update Glm to handle categorical columns natively: i.e. run them through LabelEncoder then pass that to a torch.nn.Embedding layer instead of torch.nn.Linear.

This would improve performance immensely for high-cardinality categorical features (esp. since sparse-matmul seems to be pretty slow).
@jwdink jwdink added the enhancement New feature or request label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwdink