simulated bluetooth proximity returns a p400 reader

[jdivock-stripe]

from @tomas-stripe 's feedback

I changed discover method to “Bluetooth proximity”, then tapped discover readers. I got a “SimulatorID - verifoneP400” reader back, which doesn’t seem right. I’d expect to get a simulated Chipper or M2 device.

Selecting “Bluetooth scan” as the discovery method returns the proper list of Bluetooth readers: “SimulatorID - chipper2X”, “SimulatorID - stripeM2” and “SimulatorID - wisePad3”.

[arekkubaczkowski]

@jdivock-stripe I've investigated this issue and it only occurs on Android but this is what Android SDK returns so it should be reported there.

[jdivock-stripe]

ack, assigning to @dhenry-stripe to confirm. If so we can just close his out and assume the fix will trickle down here

[dhenry-stripe]

@arekkubaczkowski The Android SDK doesn't support bluetooth proximity so this switch statement is failing to find a valid match and defaulting (incorrectly) to INTERNET when bluetoothProximity is passed in:

https://github.com/stripe/stripe-terminal-react-native/blob/main/android/src/main/java/com/stripeterminalreactnative/Mappers.kt#L114-L121

We should instead do something like:

internal fun mapToDiscoveryMethod(method: String?): DiscoveryMethod {
  return when (method) {
    "bluetoothScan" -> DiscoveryMethod.BLUETOOTH_SCAN
    "internet" -> DiscoveryMethod.INTERNET
    "embedded" -> DiscoveryMethod.EMBEDDED
    "localMobile" -> DiscoveryMethod.LOCAL_MOBILE
    "handoff" -> DiscoveryMethod.HANDOFF
    else -> throw TerminalException(TerminalException.TerminalErrorCode.UNSUPPORTED_OPERATION, "discoveryMethod:$method is not supported by Stripe Terminal Android")
  }
}

[arekkubaczkowski]

@dhenry-stripe is there any way to test localMobile, handoff or embedded connection methods? @jdivock-stripe Should it be accessible within react native SDK?

[jdivock-stripe]

I'm not sure on the current state, I'll defer to @dhenry-stripe on that

[dhenry-stripe]

@arekkubaczkowski we should just focus on the core connection methods (bluetooth and internet) for this iteration. Can you have the connection methods you mentioned return not supported exceptions?