Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Items which Need attention. #24

Closed
2 of 3 tasks
ArekBiczysko opened this issue Jan 26, 2022 · 10 comments
Closed
2 of 3 tasks

Top Items which Need attention. #24

ArekBiczysko opened this issue Jan 26, 2022 · 10 comments
Labels

Comments

@ArekBiczysko
Copy link

ArekBiczysko commented Jan 26, 2022

https://stripe.slack.com/archives/C02HQ779KC2/p1642690169068500?thread_ts=1642688726.068400&cid=C02HQ779KC2

@arekkubaczkowski
Copy link
Contributor

@jdivock-stripe

ad 2. Can you explain what you mean compatibility with Expo? If you mean ejected mode - then it should work by default (if not I will double check it)
But if you mean to have it compatible without ejecting then this is something that would need to be discussed by Stripe and Expo team to add this library to their package. Also, as far as I know it wasn't in the scope so far.

@arekkubaczkowski
Copy link
Contributor

Added estimation regarding 1, 3 and 4 point

@jdivock-stripe
Copy link
Contributor

@arekkubaczkowski I was unable to get the library working even after ejecting so that's the ask, thanks!

@jdivock-stripe
Copy link
Contributor

jdivock-stripe commented Jan 27, 2022

Hey @arekkubaczkowski thanks for the estimates! The top three asks in ranked orders are

  1. Get CI green
  2. Enable and validate payments / setupIntents / etc with internet readers (WPE/P400)
  3. Resolve errors in sample app
  4. Resolve android permission issues and functionality.

Thanks!

@jdivock-stripe
Copy link
Contributor

Also just created #28 as it looks like there's been a regression in the example app

@ArekBiczysko
Copy link
Author

hey @jdivock-stripe can you please elaborate one more time on this point:
get CI green in the repo, currently both android and ios test suites are failing even after merging remove 3rd party rn orb #16

I didn't get everything during the call and want to make sure we don't miss anything

@jdivock-stripe
Copy link
Contributor

@ArekBiczysko I've created a separate task to better track here #60

@jdivock-stripe
Copy link
Contributor

Alright, I validated the SDK works with Expo just fine, we'll just need some docs to call out any additional steps involved which I've logged as a p1 here #61

@jdivock-stripe
Copy link
Contributor

App no longer hard errors when cancelling out of discovery, but now we get the following

discCancel

@arekkubaczkowski
Copy link
Contributor

@jdivock-stripe fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants