-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button color, return URL, allowsDelayedPaymentMethods, and billing details to JS, iOS, and Android #601
Add button color, return URL, allowsDelayedPaymentMethods, and billing details to JS, iOS, and Android #601
Conversation
porter-stripe
commented
Sep 20, 2021
•
edited
Loading
edited
- Adds button color, return URL, allowsDelayedPaymentMethods, primary button color, and billing details in JS and iOS
- This is going into a feature branch in my fork, then eventually into master. For now I don't have permissions to the react native repo.
- Added allowsDelayedPaymentMethods, billing details, and primary button color to Android
@@ -40,7 +44,20 @@ export declare namespace PaymentSheet { | |||
merchantCountryCode?: string; | |||
testEnv?: boolean; | |||
}; | |||
|
|||
export interface Address { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do users see documentation for these things? I didn't find it in /docs
, do they use the native SDK docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question, this SDK (react native) isn't documented well. There will need to be some effort made to get that fixed. Not sure what that looks like in the short-term, there's many types and interfaces not documented at all...
@brnunes-stripe @michelleb-stripe latest commit 849df3d contains Kotlin/Android updates if you're interested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to figure out the logistics of pointing to the right versions of the native SDKs?
@yuki-stripe correct, once iOS and Android GA I'll throw up a quick change pointing to the latest versions, then we'll publish the RN package! Merging this into a feature branch for now... |