-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wheel dependencies on python3 #400
Comments
Hi @Ningirsu, good catch! I recently tweaked the build process to generate a single universal wheel, but failed to realize that this would include unnecessary dependencies in Python 3 environments. Using PEP 508 markers is indubitably the right thing to do here. My only concern is that support for PEP 508 was introduced relatively recently in pip (8.1.2) -- I'm not entirely sure what happens on older pip versions. Regarding @brandur-stripe wdyt? |
@Ningirsu Sorry about the trouble here, and thanks for adding the helpful remediation advice!
@ob-stripe +1 your assessment. 2.5's been deprecated since mid-2013 and it's time to move on. 2.6 and 2.7 both have a built-in I noticed that we have one more conditional check in I'm on run this week so I can put a PR together. |
@Ningirsu And actually, your PR is so close to what we'd want anyway that if you want to tweak it a little bit, we can pull it in instead of one that I make. Do you want to just drop the conditional dependencies in favor of the original Thanks again! |
@brandur-stripe Yep Sure! Just updated the PR |
Fixed in 1.79.1. Thanks again for the report and the fix @Ningirsu! |
Thanks to you for handling this so quickly! |
Hello!
Since the build was compiled using python2.7, it seems that it breaks the conditional dependencies here
https://github.com/stripe/stripe-python/blob/master/setup.py#L36
So for instance, when installing stripe on python3, we now have a dependency on
simplejson
One easy fix is to use https://www.python.org/dev/peps/pep-0508/ to manage conditional dependencies.
thks!
The text was updated successfully, but these errors were encountered: