StripeObjects are unpickleable -- when statement_descriptor is None or empty string

[hb-danny]

I'm having issues unpickling stripe objects if some of their properties are either the empty string, or None.

The following code reproduces it

ACCOUNT_STRING = 'acct_XXXXXXXXXXXXXXXX'
STRIPE_API_KEY = 'sk_test_XXXXXXXXXXXXXXXXXXXXXXXX'

import pickle
import stripe

stripe.api_key = STRIPE_API_KEY
acct = stripe.Account.retrieve(ACCOUNT_STRING)
print('acct.statement_descriptor <{}>'.format(acct.statement_descriptor))

acct.statement_descriptor = None
print('acct.statement_descriptor <{}>'.format(acct.statement_descriptor))
p = pickle.dumps(acct)
u = pickle.loads(p)

I also have this issue with raw account objects that I get back from stripe, because on most of them the acct.statement_descriptor is already the empty string, which also throws the same error.

[ob-stripe]

Hey @danny-hb, thanks for reporting this.

I've verified that the issue happens with Python 3 but with Python 2. Apparently with Python 3, when unpickling StripeObjects the values are set via the __setitem__ method, which in our case causes an issue if any attribute had an empty string as its value (here).

Fixing this will probably require defining our own __getstate__ and __setstate__ methods on StripeObject.

[brandur-stripe]

Fix released as part of 1.69.0 (thanks @ob-stripe).