Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promotion_code field not documented on class phpdocs #1058

Closed
hossein opened this issue Dec 9, 2020 · 2 comments · Fixed by #1060
Closed

promotion_code field not documented on class phpdocs #1058

hossein opened this issue Dec 9, 2020 · 2 comments · Fixed by #1060
Assignees
@remi-stripe

Comments

@hossein
Copy link

hossein commented Dec 9, 2020

promotion_code field is not documented on relevant classes, namely Discount, Customer, Subscription, and probably others.

The related field, coupon is documented on them.
@remi-stripe remi-stripe self-assigned this Dec 9, 2020
@remi-stripe
Copy link
Contributor

@hossein Thanks for reaching out! There is no promotion_code property on Customer or Subscription today so it's expected that it's not in our docs or the PHPDocs in the library!

You're correct it's missing on Discount though and I'll open a quick PR to fix this!

@remi-stripe remi-stripe mentioned this issue Dec 9, 2020
Merged
@hossein
Copy link
Author

hossein commented Dec 16, 2020

Hi @remi-stripe, thanks for consideration and for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remi-stripe remi-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve PHPDocs for Discount stripe/stripe-php
2 participants
@hossein @remi-stripe