diff --git a/lib/HttpClient/CurlClient.php b/lib/HttpClient/CurlClient.php index 2139999a98..2133522000 100644 --- a/lib/HttpClient/CurlClient.php +++ b/lib/HttpClient/CurlClient.php @@ -390,8 +390,7 @@ public function executeStreamingRequestWithRetries($opts, $absUrl, $readBodyChun &$numRetries, &$rcode, &$lastRHeaders, - &$errno, - &$message + &$errno ) { $lastRHeaders = $rheaders; $errno = \curl_errno($this->curlHandle); diff --git a/tests/Stripe/HttpClient/CurlClientTest.php b/tests/Stripe/HttpClient/CurlClientTest.php index ea0079439a..ded791e11b 100644 --- a/tests/Stripe/HttpClient/CurlClientTest.php +++ b/tests/Stripe/HttpClient/CurlClientTest.php @@ -381,11 +381,12 @@ public function tearDownTestServer() // if this flakes. public function testExecuteRequestWithRetriesCallsWriteFunctionWithChunks() { - $chunk1 = 'First, bytes'; - $chunk2 = 'more bytes'; - $chunk3 = 'final bytes'; + $chunk1 = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'; + $chunk2 = 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb'; + $chunk3 = 'cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc'; $serverCode = <<lint($indexPHP); + return $dir; } @@ -129,9 +131,6 @@ public function stopTestServer() foreach ($lines as $line) { if (self::isPHPTestServerRequestLogLine($line)) { ++$n; - } else { - \flush(); - \ob_flush(); } }