Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc on stripe objects #210

Closed
ghost opened this issue Aug 26, 2015 · 6 comments
Closed

Javadoc on stripe objects #210

ghost opened this issue Aug 26, 2015 · 6 comments
Labels

Comments

@ghost
Copy link

ghost commented Aug 26, 2015

None of the model objects have javadoc on them. It would be very useful to have javadoc on the model class declarations and accessor methods of the model objects based on the official stripe api reference. It is my understanding that documentation for model fields does not change often and would be beneficial for the consumers of this API.

If this issue is accepted I will create a pull request with javadoc (EDIT: from the API reference documentation) for all of the model classes and their field accessors.

@kyleconroy
Copy link
Contributor

@hardtoe That would be fantastic and much appreciated :D

@kyleconroy
Copy link
Contributor

@hardtoe any update here? If you don't currently have time, I'm going to move this to a "version-two" task.

@Argoday
Copy link

Argoday commented Sep 17, 2015

+1

@ghost
Copy link
Author

ghost commented Sep 17, 2015

I don't currently have time to do this. I think the "version-two" tag is the right choice...especially if it can be done as part of issue #211.

@kyleconroy kyleconroy modified the milestone: Version 2 Sep 17, 2015
@kyleconroy
Copy link
Contributor

This has now been added to the roadmap. I'm closing the issue, but feel free to continue discussing here.

@kyleconroy kyleconroy reopened this Oct 2, 2015
@ob-stripe
Copy link
Contributor

It sure took us a long time, but as of stripe-java 8.0.0, ~all fields on resource classes should have up-to-date Javadoc annotations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants