Game issues when switching window between fullscreen and windowed mode

[SoulRider]

Official Release

Version: Stride 4.0.0.1 beta04 1317

Platform(s): Windows

Describe the bug
There are multiple issues when it comes to trying to switch screen using winforms as the window renderer. Switching from windowed mode to fullscreen mode using the method game.Windows.IsFullscreen = bool will work 99.9% of the time, very occassionally ending with a NullReference in Stride.Graphics.SwapChainGraphicsPresenter.OnDestroyed();

When trying to go from fullscreen to windowed mode the system destroys the window, but seemingly a new one is not created, and the game continues to run as a background process, having to be killed in task manager. game.Windows.IsFullscreen as a swap method respects the PreferredFullscreenSize & PreferredWindowedSize values set earlier in the code.

Using game.GraphicsDeviceManager.IsFullScreen as the method to change also only works going from a windowed screen to fullscreen, although this method just seems to make the current resolution fullscreen and does not respect PreferredFullscreenSize settings.

To Reproduce
The following code is where I experience the error:

        public override void Update()
        {
            if (toggleWindow)
            {
                bool toggle = game.Window.IsFullscreen;
                toggle = !toggle;
                
                game.Window.IsFullscreen = toggle;
                Settings.SetIsFullscreen(toggle);
                toggleWindow = false;
            }
}

Expected behavior
The window to switch between fullscreen and windowed mode as apprpriate and for PreferredFullscreenSize & PreferredWindowedSize values to be respected.

Screenshots
Here is a link to a video showing the window not coming back up after switching from fullscreen to windowed mode.

https://youtu.be/5klndyDkLX8

[SoulRider]

I have had a 33% return rate on my game due to this issue. I have been able to get some further information including event viewer logs, but this is a serious issue. Note in my game I only go from the default intro window to fullscreen at launch, no other changes.

Please see some event viewer logs on this issue:

[tebjan]

I think Winforms isn't the recommended windowing system, SDL has seen more fixes recently. Just switch to SDL and set how it works. It also has FullscreenIsBorderlessWindow which would allow switching between apps while in fullscreen.

Also, it's not recommend to use the methods of the graphics device manager. Only talk to the window. That's how we currently do it and it's quite smooth and reliable.