web: pinned tab fixes #7692
Open
web: pinned tab fixes #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix pinned tab not working after page reload * fix note opening in new tab even if its tab is present when active note is pinned Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
thecodrr
requested changes
Mar 1, 2025
Comment on lines
+662
to
+665
| /** | ||
| * Should be true if we want to open a new tab when the active tab is pinned | ||
| */ | ||
| considerPinnedTab?: boolean; |
There was a problem hiding this comment.
This method, openSession, can be called in various situations. In these situations, activeTab doesn't have a consistent definition. For example, openSession is called here:
- Opening a note on click on the notes list. When the method is called here,
activeTabis the tab that is currently active in the editor NOT the tab we're trying to open. - Focusing a tab. When the method is called here,
activeTabis the tab we're trying to open. If that tab is already pinned, I'll never be able to open the tab this way at all, it will always open a new tab.
The current logic to open in new tab for pinned active tab is flawed in this sense as openSession method doesn't have a way to differentiate between those two scenarios. I think the current approach where the caller of openSession decides to consider active tab is okay for now, the only other fix I could think of was maybe a refactor of several editor-store methods.
Do let me know what do you think about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7683