Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App goes back to english language #5942

Closed
elBlacksmith opened this issue Oct 2, 2024 · 14 comments
Closed

App goes back to english language #5942

elBlacksmith opened this issue Oct 2, 2024 · 14 comments
Labels

Comments

@elBlacksmith
Copy link

How to Reproduce
In an android phone with English in the system, setting the app in Spanish and use it until it starts showing the texts in English.

Expected Behavior
I was expecting to use the app in Spanish

Versions affected
StreetComplete 59.1 and Android 14 (Xiaomi HyperOS 1.0.7.0)

Hi, so I am using this app to fill the questions. My phone is android, and I have set English as the default language in the phone. I use StreetComplete in Spanish (In order to avoid mistakes). But after using it a while, (Like checking 15-20-25 tasks in my surroundings. Sometimes more time, other less time) the app starts showing texts in English. Like the display of "Type kind of place here".

@matkoniecz
Copy link
Member

matkoniecz commented Oct 2, 2024

Looking at https://github.com/streetcomplete/StreetComplete/blob/master/CONTRIBUTING.md#translating-the-app and https://poeditor.com/projects/po_edit?id_language=152&per_page=20&id=97843 - Spanish should be fully translated (though maybe at time of last release it was not fully translated?)

what exactly is showing in English? Maybe iD presets are not fully translated?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 2, 2024
@elBlacksmith
Copy link
Author

Looking at https://github.com/streetcomplete/StreetComplete/blob/master/CONTRIBUTING.md#translating-the-app and https://poeditor.com/projects/po_edit?id_language=152&per_page=20&id=97843 - Spanish should be fully translated (though maybe at time of last release it was not fully translated?)

what exactly is showing in English? Maybe iD presets are not fully translated?

It's not about lack of translation, it's that those menus first are in Spanish and suddenly are in English.

Unfortunately it's quite random, so I cannot describe a way to replicate.

@matkoniecz
Copy link
Member

If you go back to app settings - is it still set to Spanish?

If you check later similar menu - is it in Spanish again or stuck in English?

@elBlacksmith
Copy link
Author

If you go back to app settings - is it still set to Spanish?

If you check later similar menu - is it in Spanish again or stuck in English?

Hi, I was about to reproduce the error.

I did like 5 tasks with everything in Spanish, and then I put my phone on the pocket. After 30-45 minutes I took my phone, unlocked it, the app was shown the first thing, and everything was on English. Well, not everything, the settings and "my profile" were still in Spanish. On the settings it was still selected Spanish as the application language.
But after looking the menus in Spanish I went back to the main screen of the app and the English texts are still there.

Once I killed the app the Spanish texts are back.

I have attached screenshots after the bug happened.

Screenshot_2024-10-04-14-27-34-327_de westnordost streetcomplete
Screenshot_2024-10-04-14-27-27-008_de westnordost streetcomplete
Screenshot_2024-10-04-14-27-19-888_de westnordost streetcomplete
Screenshot_2024-10-04-15-17-35-468_de westnordost streetcomplete
Screenshot_2024-10-04-15-17-17-656_de westnordost streetcomplete

@matkoniecz matkoniecz removed the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 4, 2024
@westnordost
Copy link
Member

And your system language is set to English, right?

Overriding the system language is a bit of a hack in Android, apparently this kind of hack does not work properly on either Android 14 and/or HyperOS.

The settings, about and user screens are still working correctly and are correctly in Spanish because those screens use a different UI framework (not Android, but Jetpack Compose), which manages the whole localization thing differently. That's the reason why it always works there, I presume.

@westnordost
Copy link
Member

I don't have an Android 14 at hand, can anyone with an Android 14 reproduce this?

@matkoniecz
Copy link
Member

matkoniecz commented Oct 4, 2024

And your system language is set to English, right?

It seems so from "In an android phone with English in the system"

@elBlacksmith
Copy link
Author

And your system language is set to English, right?
Yes, that's correct.

@mnalis
Copy link
Member

mnalis commented Oct 6, 2024

I don't have an Android 14 at hand, can anyone with an Android 14 reproduce this?

I've tried it now in Espanol (solving dozen quests, putting it in background for few hours, solving dozen more quests), but couldn't reproduce on my Android 14 (Samsung Galaxy S23+).

I've also haven't noticed such behaviour previously on my Croatian StreetComplete (but I would be likely to miss it if it did happen, as I use combination of English SCEE and Croatian StreetComplete. System language is always English). I'll try to pay it closer attention if I can spot it in the future days...

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 9, 2024
@westnordost
Copy link
Member

(Adding feedback required because it couldn't be reproduced by other users yet. We don't know if it is limited to Android 14 only, or HyperOS only, etc)

@riQQ
Copy link
Collaborator

riQQ commented Oct 9, 2024

I changed the language some days ago and couldn't reproduce the issue so far. I haven't interacted much with StreetComplete though.

I'm using a Pixel 6a with stock ROM / Android 14.

@meiphoo7-Mae
Copy link

In my situation it is just the other way around. The system setting of my phone (Android 10; SC 59.3) is Dutch but I prefer SC to present questions in English and SC does so for a certain amount of time until the phone is tilted a little causing the app to change from portrait mode to landscape mode. After that the questions are in Dutch and only killing and restarting the app will make it return to English again.
Unfortunately the problem is hard to reproduce. Sometimes the problem does not occur at all, sometimes the problem can occur immediately after the first rotation attempt. Usually it takes some time for the problem to occur, but it seems completely unpredictable to me. The duration of how long the app is active might be important in this situation.
If I'm very careful and take care not to rotate my phone, it'll not change the language AFAICT. I haven't tested what happens if I disable the auto-rotate function in Android.

@riQQ
Copy link
Collaborator

riQQ commented Oct 30, 2024

I think I found the pattern and it's reliably reproducible for me using StreetComplete V59.2 on Android 14 and auto rotate active.

Device language set to German, StreetComplete language set to English.

Whenever you rotate the screen with the quest dialog open, the language will switch to German (the language from the Android system settings) when opening a new dialog. The currently open dialog doesn't change and keeps the previous language.
Whenever you rotate the screen with the quest dialog not open, the language will switch to English (the language from the StreetComplete settings) when opening a new dialog.

@elBlacksmith
Copy link
Author

I think I found the pattern and it's reliably reproducible for me using StreetComplete V59.2 on Android 14 and auto rotate active.

Device language set to German, StreetComplete language set to English.

Whenever you rotate the screen with the quest dialog open, the language will switch to German (the language from the Android system settings) when opening a new dialog. The currently open dialog doesn't change and keeps the previous language. Whenever you rotate the screen with the quest dialog not open, the language will switch to English (the language from the StreetComplete settings) when opening a new dialog.

Good catch.
@matkoniecz I was able to replicate the bug following riQQ's feedback. My Spanish UI changed to English (System language) after rotating the screen with a dialog opened.

Probably that's the reason that made me open this ticket.

@riQQ riQQ removed the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants