-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Is this still here' asked immediatly after 'vegetarian option' has been filled #5729
Comments
What did you answer? Can you link the element for which this happened? (AFAIK the implementation for #5674 should work for any quest) |
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for the feedback. Here is the restaurant: https://www.openstreetmap.org/node/5138626545 I've been trying on other random restaurants, and indeed I can't reproduce it on other places. I'm happy to close the issue and reopening it once I found another ☺ |
Thanks for the link! I now can reproduce in 58.1 on any restaurant having old small_Screen_Recording_20240708_210537_StreetComplete.mp4 |
Looking at the changesets from @Mbodin, the diet:vegetarian quest (cs) did not remove I think this might be due to StreetComplete/app/src/main/java/de/westnordost/streetcomplete/osm/ResurveyUtils.kt Lines 41 to 53 in fa538aa
(Another SC 58.1 example is this node where |
So, when
the question is: what good is a
should be expanded to include Thoughts? |
Uhm... my first thought would be removing/updating the general check date should maybe be done independently of whether the per-key check date is updated. But I haven't looked closely at the code yet, and I figure if I would, I would already implement a solution. Right now, as this is neither urgent nor important, I am busy with other stuff. |
I think the easy solution is to also set the check-date-for-key if the generic check date is set. |
This is a similar issue than #5674, but with the vegetarian option of a restaurant: it would be nice not to ask whether a restaurant is still there if we just answered that it had vegetarian option.
How to Reproduce
Similar than in #5674, select a restaurant with a quest asking whether is has a vegetarian option.
After completing the vegetarian quest, I was being asked whether the restaurant is still there.
Note that I possibly have changed the order of appearance of my quests: that might be the issue.
Expected Behavior
If completing a quest about a restaurant, it must be there, so this quest came as a surprise.
Versions affected
Android 13
StreetComplete v58.1
The text was updated successfully, but these errors were encountered: