Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noexit=yes is displayed over road class in object descriptions #4695

Closed
matkoniecz opened this issue Dec 19, 2022 · 3 comments
Closed

noexit=yes is displayed over road class in object descriptions #4695

matkoniecz opened this issue Dec 19, 2022 · 3 comments
Assignees

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Dec 19, 2022

See https://www.openstreetmap.org/way/714073113

screen01

(yes, noexit=yes on way is a bad tagging scheme - but accepted enough to make mass removing it as approach that is not viable)

iD using its presets displays it correctly - see https://www.openstreetmap.org/edit?editor=id&way=714073113#map=19/52.61365/13.43482

screen02

This seems distinct from building=yes displaying bad labels for multipolygon buildings as highway=living_street is defined without catchall.

@matkoniecz matkoniecz changed the title noexit=yes is displayed over road class noexit=yes is displayed over road class in object descriptions Dec 19, 2022
@Helium314
Copy link
Collaborator

I suspect the difference comes from SC determining feature by tags only.
iD probably doesn't show No Exit because noexit=yes is not valid on a way, but SC doesn't check geometry type, see

// not for geometry because at this point we cannot tell apart points and vertices
// .forGeometry(element?.geometryType)

(now with the cache, such a geometry check might be more feasible)

@matkoniecz
Copy link
Member Author

Also, even if points and vertices or way and areas cannot be distinguished we can still distinguish points/vertices from ways/areas.

@westnordost
Copy link
Member

Let's do the solution @matkoniecz mentioned, it doesn't introduce any more new calls to the (hopefully) cached data but also solves this issue.

@westnordost westnordost self-assigned this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants