Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipolygon POIs not rendered correctly #4689

Closed
legofahrrad opened this issue Dec 16, 2022 · 6 comments
Closed

Multipolygon POIs not rendered correctly #4689

legofahrrad opened this issue Dec 16, 2022 · 6 comments
Assignees
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@legofahrrad
Copy link
Contributor

How to Reproduce
click on the opening hours quest of https://www.openstreetmap.org/node/9230317945 and see that https://www.openstreetmap.org/relation/5462872 is also highlighted in purple as expected. But it looks weird because it's a multipolygon. See Screenshot below.

grafik

Expected Behavior
Multipolygons should be coloured inside of outer ways only.

Versions affected
v50.0

@westnordost westnordost self-assigned this Dec 16, 2022
@westnordost
Copy link
Member

The issue was that the second polygon was incorrectly interpreted as an inner ring of the first polygon.

@legofahrrad
Copy link
Contributor Author

Using v50.1 and the issue isn't fixed yet. Looking at the example from the Hackerspace Bremen, it is still displayed as in the screenshot from the first comment.

@westnordost
Copy link
Member

westnordost commented Dec 28, 2022

I explicitly tested it with the Hackerspace. So maybe the remaining issue is specific to the Android version you use? Which one do you use? Can anyone else reproduce it?

@westnordost westnordost reopened this Dec 28, 2022
@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Dec 28, 2022
@legofahrrad
Copy link
Contributor Author

I'm on a Pixel 5 with Android 13

@westnordost
Copy link
Member

Oh, I get it. Could it be that it is reproducible if you select an object near the hackerspace but it looks fiine if you select the hackerspace itself?

@legofahrrad
Copy link
Contributor Author

yes, when using the shop overlay (because the hackerspace has no quest on it) and selecting the hackerspace, it works all fine. The orange highlighting is correct displayed.
When selecting a POI nearby (e. g. the "Bremer Textildruck" Fabric Store) the pink highlighting is displayed wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

2 participants