Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload changes in a collection #3196

Closed
debuglevel opened this issue Aug 20, 2021 · 3 comments
Closed

Upload changes in a collection #3196

debuglevel opened this issue Aug 20, 2021 · 3 comments

Comments

@debuglevel
Copy link

debuglevel commented Aug 20, 2021

Use case

After collecting a hundred quests in offline mode, I upload them at home and watch how each single change is uploaded. That's not really a big deal, but still seems a bit odd.

Proposed Solution

If there is an OSM endpoint to upload a collection of changes, upload all of them in a single request. If there is no such endpoint: just close this issue 😀

@westnordost
Copy link
Member

westnordost commented Aug 20, 2021

It is possible, this is how all other editors do it. However, it is not possible in StreetComplete. I explain how the upload works here, if you are interested:

https://www.youtube.com/watch?v=Amk_Yvyau7A

(For uploading each individual change, the app first downloads the most current version of the element(s) it is going to change. This takes longer but makes conflict handling easier.)

I think the thing that bothers you the most is that all the quests on the map blink all the time during upload. This is an issue of the map rendering and cannot be fixed (without exchanging the map renderer, see #3123. What you can do, is just send the app into the background, it will continue to upload the changes.
However, currently it might be that after some time, the app will stop / cancel uploading further when it is in the background for too long. I didn't test it, but I think this may happen. However, this would be fixed as a side effect of fixing #2967 .

@debuglevel
Copy link
Author

It was rather mere curiosity why they are not handled together. Thanks for the explanation! :-)

@westnordost
Copy link
Member

Ok, short answer: If the upload for one change fails due to a conflict, it doesn't matter for the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants