Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to view photo before uploading it to new note. #2497

Closed
j13m126 opened this issue Jan 13, 2021 · 5 comments · Fixed by #4797
Closed

Option to view photo before uploading it to new note. #2497

j13m126 opened this issue Jan 13, 2021 · 5 comments · Fixed by #4797

Comments

@j13m126
Copy link

j13m126 commented Jan 13, 2021

Hello there. I've been using StreetComplete a lot in the Christmas Holidays answering questions and adding notes. I really enjoy using it, thank you!!

So I was walking through the neighborhood looking for doctor's offices that haven't been added yet to osm. Due to the cold temperatures I thought I could create a note adding a photo of the door with the street address and the practice sign (like this), so that me or others could then add it. As you can see, I sometimes uploaded a blurry photo, which is really annoying.

Proposed Solution
Therfore I would like to request the option to view the photo before uploading it to a note. I always tried to get the street address and the practice sign on one photo (for verification purposes), but I could'nt make sure that the text was readable.
I think this option would also benefit other scenarios..

@matkoniecz
Copy link
Member

matkoniecz commented Jan 13, 2021

It may be controlled by system - on my phone after taking a photo I have it displayed at a full screen preview and I can

(1) accept photo
(2) reject and retry
(3) go back without taking photo

not sure is it something that can be controlled by StreetComplete

(I have an unmodified clean Android 10, just degooglified a bit)

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Jan 14, 2021
@j13m126
Copy link
Author

j13m126 commented Jan 14, 2021

Oh, you are right. I previously had LineageOs installed. After flashing PixelExperience I now have the same options as you described above. My bad, I didn't think of that. Thank you!

@matkoniecz
Copy link
Member

Sounds like OS-level issue not solvable by SC (in theory maybe SC could reimplement photo taking but this would be ridiculous)

@mnalis
Copy link
Member

mnalis commented Jan 14, 2021

What might be done is after the picture is taken, it is added to the list of pictures below note text, where you can click on it to remove it.

What I would suggest is when picture is clicked, instead of asking to remove it we show it full screen in size what is going to be uploaded to the servers (allowing for zoom in/out) and then have a button there to remove picture.

That would solve two problems:

  • picture review on older android versions
  • actually seeing what is going to be uploaded and if it is readable (as I believe picture gets reduced in size/quality before upload). It so happens that sometimes picture is readable on mobile (or looks like it should be, as zoom does not work when accepting pictures in SC on my phone) but when the result is uploaded letters are too blurry.

@westnordost westnordost added enhancement and removed feedback required more info is needed, issue will be likely closed if it is not provided labels Jan 14, 2021
@westnordost
Copy link
Member

Certainly a valid feature request, but very low priority. PR is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants