Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useUpdateEffect not calling returned function on unmount #863

Closed
adesurirey opened this issue Jan 7, 2020 · 1 comment · Fixed by #864
Closed

useUpdateEffect not calling returned function on unmount #863

adesurirey opened this issue Jan 7, 2020 · 1 comment · Fixed by #864
Labels
released

Comments

@adesurirey
Copy link
Contributor

What is the current behavior?
Does not call the returned function on unmount

Steps to reproduce it and if possible a minimal demo of the problem
https://codesandbox.io/s/gifted-hopper-tb9gn

What is the expected behavior?
Should call returned function when unmounting

A little about versions:

  • OS: macOS 10.15.2
  • Browser (vendor and version): Google Chrome 79.0.3945.88
  • React: 16.12.0
  • react-use: 13.14.0
  • Did this worked in the previous package version? idk
@adesurirey adesurirey changed the title useUpdateEffect not calling function on unmount useUpdateEffect not calling returned function on unmount Jan 7, 2020
@adesurirey adesurirey mentioned this issue Jan 7, 2020
Merged
13 tasks
@streamich
Copy link
Owner

🎉 This issue has been resolved in version 13.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: useUpdateEffect returns optional cleanup function
2 participants
@streamich @adesurirey