Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: useWindowScroll - for cross-browser compatibility #480

Merged
merged 1 commit into from
Jul 25, 2019
Merged

feat: useWindowScroll - for cross-browser compatibility #480

merged 1 commit into from
Jul 25, 2019

Conversation

jeemyeong
Copy link
Contributor

For cross-browser compatibility, use window.pageYOffset instead of window.scrollY.
(https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY)

@jeemyeong
feat: useWindowScroll - for cross-browser compatibility
5987cc8 
For cross-browser compatibility, use window.pageYOffset instead of window.scrollY.
(https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY)
streamich
streamich approved these changes Jul 25, 2019
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamich streamich merged commit e37dd8d into streamich:master Jul 25, 2019
streamich pushed a commit that referenced this pull request Jul 25, 2019
@semantic-release-bot
chore(release): 10.2.0 [skip ci]
6ed4a30 
# [10.2.0](v10.1.2...v10.2.0) (2019-07-25)

### Features

* useWindowScroll - for cross-browser compatibility ([5987cc8](5987cc8))
* useWindowScroll - for cross-browser compatibility ([#480](#480)) ([e37dd8d](e37dd8d))
@streamich
Copy link
Owner

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeemyeong @streamich