feat: support stream as source in promises version of writeFile
#1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoulKa
force-pushed
the
feature/#1068-stream-source-in-promises-writefile
branch
3 times, most recently
from
767b585
to
347abc0
Compare
SoulKa
force-pushed
the
feature/#1068-stream-source-in-promises-writefile
branch
from
347abc0
to
449035d
Compare
SoulKa
changed the title
G-Rath
changed the title
writeFile
G-Rath
approved these changes
Oct 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2024
# [4.14.0](v4.13.0...v4.14.0) (2024-10-13) ### Features * support stream as source in promises version of `writeFile` ([#1069](#1069)) ([11f8a36](11f8a36))
|
🎉 This PR is included in version 4.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now supporting streams as
writeFile()data source in the Promises API, which makes it more compliant to the Node.js Promises API.What's still missing is the support for
AsyncIterableandIterable. I can implement them as well if this PR gets approved.Closes #1068