Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rust 1.42 (beta) failures in Travis CI #139

Closed
mulkieran opened this issue Jan 30, 2020 · 3 comments
Closed

Fix Rust 1.42 (beta) failures in Travis CI #139

mulkieran opened this issue Jan 30, 2020 · 3 comments
Assignees
@mulkieran

Comments

@mulkieran
Copy link
Member

Rust 1.41 has been released and we're experiencing some beta failures.
@mulkieran
Copy link
Member Author

mulkieran commented Jan 30, 2020 •
edited
Loading

It looks like error_chain will cut a new release which will cause the error_chain lints to go away:
rust-lang-deprecated/error-chain#285. So we should leave those alone, and just address the non error_chain problems.

@mulkieran mulkieran assigned mulkieran and unassigned bgurney-rh Jan 30, 2020
@mulkieran
Copy link
Member Author

Whoops! These errors have to do with Rust error management and the Error trait, so we made need to figure out a broader fix. We define description in our own errors in stratisd and devicemapper.

This was referenced Feb 6, 2020
Merged
Merged
@mulkieran
Copy link
Member Author

Resolved by attached PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mulkieran @bgurney-rh