New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IETF language tags as file names #34

Closed

DanielBiegler opened this issue Oct 1, 2017 · 1 comment · Fixed by #49

Labels

enhancement good first issue help wanted

Collaborator

DanielBiegler commented Oct 1, 2017

The author of Pannellum, @mpetroff, mentioned that one could use the IETF language tags instead of the currently used ISO 3166 ones.

I'm not against this. If someone wants to do this, go ahead and make a PR.

DanielBiegler added enhancement hacktoberfest help wanted labels

DanielBiegler added the good first issue label

DanielBiegler removed the hacktoberfest label

Owner

strarsis commented Feb 21, 2018 •

edited

Loading

IETF language tags list: https://datahub.io/core/language-codes#resource-ietf-language-tags
ISO 3166 list: https://datahub.io/core/country-list

But aren't these tags basically the same? Doesn't it make only sense when dialects are used?

strarsis mentioned this issue

Use IETF language tags for translation filenames #49

Merged

strarsis closed this as completed in #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment